DanielLeens commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5322435482
Thanks for circling back, @SEZ9 — good questions, here are the specifics. **1. Resolution of the two merge-blocking findings:** Both were closed on head `a3af71a13cd1` (2026-07-24), confirmed in my re-review at that time: - **Blocker 1 (`lastPositionChangeAt` measured at collection time, not when the position changed)** — `CdcReaderProgressTracker` was changed so `recordEmission()`/`nextState()` only adopts the new `observedAt` timestamp when the emitted offset actually changes (the `emittedPositionChanged` check); otherwise the previously stored timestamp carries forward. I re-verified this again in my latest full review (head `244c3bf2a`, 2026-08-15) and it's still correct — unchanged since the July fix. - **Blocker 2 (enumerator reports ordered by wall-clock instead of a monotonic same-attempt sequence)** — `CdcProgressService.newerReport()` now orders by execution-attempt first (strictly greater wins), then by a per-task `reportSequence` within the same attempt (strictly greater wins), not `observedAt`. Also re-verified unchanged on the current head. Both fixes predate the ownership/consolidation discussion you and @nzw921rx have been having, so they're independent of that thread. **2. Current head + CI:** Current head is `244c3bf2ab31c188fad816425132d67c3eb9ace0`. Live status just now: required `Build` check is `SUCCESS`, `mergeable` is `MERGEABLE`. Note `mergeStateStatus` is still showing `BLOCKED` — that's because your last formal review (2026-07-24, `CHANGES_REQUESTED`) is still the standing review state on this PR; it hasn't been updated by a new formal review action even though we've since discussed and closed several of the follow-up items in comments. Worth re-reviewing and updating your review state once you've confirmed the above, since that's what's actually gating the merge button now, not CI. My Issue Summary/merge recommendation from the 2026-08-15 review stands — no open source-level blocker from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
