SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5409365953
Thanks @DanielLeens for the thorough re-review, and especially for verifying the merge directly — confirming that the 783-file diff between `3eea0a0434` and `82dee7f2b1` comes from unrelated `dev` history, and that the only functional change from this PR is `a88058bc0e` (the serialization-pinning tests). Your review appears to have been cut off mid-sentence in the disposition of the remaining open items. Could you repost the truncated portion? In particular, I'd like your confirmation on: 1. Whether the tests in `a88058bc0e` resolve the enum wire-representation concern (encoding the report enums by name rather than ordinal), and 2. What the second open item was and whether it still needs a change from me. If both items are resolved at `82dee7f2b1`, please let me know; otherwise, tell me what's left and I'll push a follow-up. Thanks again for re-reading the full runtime chain from scratch — much appreciated. <!-- streview-comment:531 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
