zhang-arvin commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5357503233
Hi @nzw921rx, I (@zhang-arvin) originally claimed 3 connectors for this umbrella issue, but after analyzing the current code, I found they already use declarative `optionRule()` validation and do **not** need migration: ### ✅ Already compliant (no migration needed) | Connector | Status | Details | |---|---|---| | **connector-hudi** (Sink) | ✅ Compliant | `HudiSinkFactory` has `optionRule()` with `.required()`, `.exclusive()`, `.optional()` | | **connector-hive** (Both) | ✅ Compliant | `HiveSourceFactory` has `optionRule()` with `.optional(...)`; `HiveSinkFactory` has `optionRule()` with `.required(...)`, `.optional(...)` | | **connector-starrocks** (Both) | ✅ Compliant | `StarRocksSourceFactory` has `optionRule()` with `.required()`, `.optional()`, `.exclusive()`; `StarRocksSinkFactory` has `optionRule()` with `.required()`, `.optional()`, `.conditional()`, `Conditions.extension()` | These 3 connectors can be removed from the migration list. ### 🔧 connector-doris — needs work `DorisSinkConfig` still has an imperative `validateDirectWriteOptions()` method (line 144-154) that checks `direct_to_be=true` requires `benodes`. This should be migrated to declarative `conditional()` in the optionRule. I will take this one and submit a PR. Please unclaim connector-hudi, connector-hive, and connector-starrocks from my name, and keep me on connector-doris. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
