Linz1248 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5422195180
I would like to work on **connector-pulsar**. **Plan** (migrate imperative validation to declarative `optionRule()`, following #10976/#10977 and the merged pattern in #11095): - `PulsarSourceFactory`: `subscription.name` is declared `.optional(...)`, but the option has no default, its description states it is required when constructing the consumer, and `PulsarConsumerConfig.build()` throws on a blank value. Move it to `.required(...)` so jobs fail at submission time instead of deep in source construction. - Remove the now-redundant presence checks in the `PulsarAdminConfig` / `PulsarClientConfig` / `PulsarConsumerConfig` builders (already covered by `required(CLIENT_SERVICE_URL, ADMIN_SERVICE_URL)` and the rule above). - Keep the transaction-coordinator check in `PulsarConfigUtil` as runtime-only validation, per the guide. - Add factory unit tests covering the validation paths, following the #11095 pattern. - Verify the multi-table path (`PulsarTableConfig#getSubscriptionName`) during implementation to confirm required-at-top-level is correct there too. The PR will target `dev` and reference this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
