SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5366241217
@RohanExploit Thanks for volunteering — `connector-file` is yours. Your recent work in that module should make this a smooth one, and following the pattern from the merged migrations (keeping optional semantics optional) is exactly the right approach. A few asks before you open the PR: 1. Since `connector-file` covers multiple file-based factories, please note in the PR description which source/sink factories you touched, so reviewers can check the scope quickly. 2. Keep the change scoped to this connector and target the `dev` branch. 3. Add focused validation tests covering both valid and invalid configurations for any checks you migrate. 4. Link the PR back here once it's ready so we can track it against the table. If you find any factories in the module that are already fully declarative and need no migration, please call that out here as well so we can update the table accordingly. Thanks! <!-- streview-comment:416 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
