SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5385642887
Thanks @zhang-arvin for the detailed analysis and for taking the time to verify the current state of the code before starting work — that saves everyone effort. Based on your findings: - **connector-hudi** (Sink), **connector-hive** (Both), and **connector-starrocks** (Both) will be unclaimed from your name and marked as already compliant, since they already use declarative `optionRule()` validation with no imperative checks left to migrate. - **connector-doris** (Both) stays assigned to you for migrating the imperative `validateDirectWriteOptions()` check in `DorisSinkConfig` to a declarative `conditional()` in the optionRule. Remaining asks: 1. Please link the connector-doris PR here once it is open so we can track it against this umbrella issue. 2. In that PR, please keep the change scoped to connector-doris only, remove the duplicate runtime check once the `conditional()` rule covers it, and include validation tests for both the valid case and the failure case (`direct_to_be=true` without `benodes`). Thanks again! <!-- streview-comment:482 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
