Linz1248 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5423581969
Follow-up on my plan above: after digging into the multi-table path during implementation, I'm **not** promoting `subscription.name` to `.required(...)`. In multi-table mode each `tables_configs` entry can override `subscription.name`, with fallback to the global value — marking the top-level option required would reject jobs that only set subscriptions per table. `PulsarMultiTableConfig.validateTableConfig` already validates `subscription.name` for both the single-table and the per-table paths (with config prefixes in the error messages), so that validation stays where it is. Instead, the PR removes the builder checks that this validation (and the factories' `required(CLIENT_SERVICE_URL, ADMIN_SERVICE_URL)`) already shadows, and adds `ConfigValidator`-based factory tests for the source/sink option rules. PR: https://github.com/apache/seatunnel/pull/11972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
