DanielLeens commented on PR #12015: URL: https://github.com/apache/seatunnel/pull/12015#issuecomment-5578481706
@luozihen Congratulations on getting CI all the way to green, and welcome to the Apache SeaTunnel community — this has been a genuinely solid first contribution, and the way you dug into the HOCON/CI issues yourself along the way was great to see. Where things stand right now, for your reference: I approved this PR on my side after the last round of fixes, and the latest run on `1730aeef` is fully green (Build, labeler, and the notify workflow all completed successfully). On next steps, here is roughly how it works in an Apache project like this one: 1. **My approval alone isn't enough to merge.** Apache SeaTunnel requires review/approval from a project committer with merge rights before a PR can go in — my account here doesn't hold that permission, so a second maintainer still needs to look this over. That's normal and not a sign anything is wrong with your PR. 2. **@SEZ9 is doing exactly that second pass** — they've already asked for a short checklist confirming which items from the earlier review round your last push addressed. Please answer that when you have a moment; it'll let them wrap their confirmation quickly. 3. **Timeline**: since SeaTunnel is a volunteer-driven Apache project, maintainer availability varies — it can take anywhere from a few days to a couple of weeks to get a second reviewer's attention, especially for a larger feature PR like this one. There's nothing further you need to do to speed this up beyond answering open review questions promptly; no need to re-ping unless it's been quiet for a while. 4. Once a maintainer with merge rights approves, they (or another committer) will merge it — normally as a squash merge onto `dev`. Thanks again for your patience through the CI back-and-forth, and for the clear, cooperative communication throughout review — that makes this a lot smoother for everyone. Nicely done for a first PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
