abdessalems commented on PR #11727:
URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5674932827
Thanks @DanielLeens for tracking those down. One precision point for @SEZ9's
scope, since both answers describe code that's on the current head but came
in
via #12238, not this PR's diff:
1. testStaleTaskDoneCleansOnlyOwnedGenerationResources is already on dev from
#12238 — this PR doesn't add it. The only test method #11727 adds to
TaskExecutionServiceTest is testMissingTaskClassLoaderFailsFast, plus the
helper fix. So the redeploy-vs-taskDone coverage on cancellationFutures is
provided by #12238, which is consistent with where F1/F5 were deferred.
2. finishOwnedResources() doesn't appear in this PR's diff at all, so
there's no
monitor claim of mine left to check — that Javadoc is #12238's.
What this PR actually changes: BlockingWorker.run() in
TaskExecutionService.java,
TaskDeployStaleContextRaceTest (the deploy-returns contract), and the one
test
above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
