abdessalems commented on PR #11727:
URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5651359624
@SEZ9 @DanielLeens — agreed, I'll strip this back to the latch fix and carry
F1/F2/F4/F5/F6/F8 over to the #12238 discussion.
One check on scope before I rewrite the branch, so I don't have to do it
twice.
Taken literally, "only the unconditional startedLatch release" would also
drop
two commits that aren't part of the ownership model:
- 8122bdbfa — don't close a task whose init() never ran
- 370f175e8 — the getClassLoaders() null guard
Both were @DanielLeens's own blockers from earlier rounds, and both are
required
by the latch fix itself rather than by the ownership work: moving the context
lookup inside the try block is what first makes finally — and so taskDone()
and
close() — reachable on the failure path. Dropping them would reintroduce the
silent NPE that was blocked on in September.
So my plan is to keep:
b91e00582 the latch release
23011fd7d its regression test
79eebc554 the startLatchReleased rename
8122bdbfa the close() guard
370f175e8 the getClassLoaders() guard (splitting out its stale-branch leak
fix, which is ownership-related)
b69dc1161 the test-helper fix the guard needs
d98cfb608 the restored iteration count and timeout
and drop 588314d9c, 1fed68145, 912e8bd4c, e66911c0c, f1e02f942, dba310df1,
2e9d60570, e9b25d84d plus the CI-retrigger commits.
Does that match what you had in mind? It needs a force-push to rebuild the
branch on current dev, so I'd rather confirm the line first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
