abdessalems commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5652234280
Rebased onto dev now that #12238 has merged, and stripped this back to the original scope as @DanielLeens and @SEZ9 suggested. What's left is 3 files, +370/-11: the unconditional startedLatch release for #11679, its regression test, and the two guards that the latch fix itself makes necessary — a missing per-task class loader now fails fast instead of installing a null context class loader, and close() only runs on a task whose init() was attempted. Dropped: the three cherry-picked ownership commits from #11757 (588314d9c, 1fed68145, 912e8bd4c), the OwnedFuture work built on them, and the ownership Javadoc — all superseded by #12238. The merge conflict with dev is gone as a result. @SEZ9 — F1, F2, F4, F5, F6 and F8 were all about that ownership model, so as you asked they belong on the #12238 discussion rather than here. F7's reflection concern no longer applies, since the test no longer reaches into the ownership internals. Locally green: 21 tests, 0 failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
