abdessalems commented on PR #11727:
URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5725650648
@SEZ9 — to answer directly: "not touched by this diff" means that code is no
longer in this PR at all, not that the last push left it unchanged.
Those findings were raised against the ownership model this PR carried while
it
had the three commits cherry-picked from #11757 (588314d9c, 1fed68145,
912e8bd4c). That model was removed when I rebased onto dev and stripped the
PR
back on @DanielLeens's and your suggestion. Checking the current head:
finishOwnedResources dev: 0 occurrences PR head: 0
finishExecutionContext dev: 0 PR head: 0
cancelOwnedAsyncFunctionsInPlace dev: 0 PR head: 0
They aren't on dev either — #11757 was closed unmerged, and #12238 solved the
same problem with a different design (finishExecution() with an
identity-checked
compute()). So F4, F6 and F8 have no code left to apply to here.
Same for F1/F3/F5: this PR's diff contains zero occurrences of
deployLocalTask.
The plain put you're asking about is dev's code, unchanged by this PR — if it
still needs addressing it belongs against #12238's design, not here.
The whole diff is three hunks: one import removal and two inside
BlockingWorker.run(). Happy to be shown otherwise if you spot something I've
missed.
On F7 coverage — since F1/F5 aren't in this PR, the redeploy-vs-taskDone race
lives entirely in dev's code. I can add a comment in the test pointing at
that if
you'd like it recorded, as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
