201811510411lw commented on PR #12301: URL: https://github.com/apache/seatunnel/pull/12301#issuecomment-5710443281
Thanks @DanielLeens. I have extracted the focused routing changes and opened [zhangshenghang/seatunnel#19](https://github.com/zhangshenghang/seatunnel/pull/19) against this PR's source branch, `fix/12243-paimon-fixed-bucket-routing`. It contains one incremental commit, [`326f4f91e`](https://github.com/201811510411lw/seatunnel/commit/326f4f91e9a47d7b2077ce32da3ae2518937eabb), directly on `48264cda6`, addressing the three review items: - Resolve routing through the actual `MultiTableSink` wrapper, including per-table routing and conflicting-target/configuration checks. - Dispatch schema-control rows by `schema_subtask_id`, bypassing data conversion, with broadcast delivery to each sink subtask. - Exercise the real factory/processor path with Flink MiniCluster and Paimon readback, plus control-row destination regressions and an updated Paimon E2E case. This keeps the existing `SupportSinkDataPartition` / `SinkDataPartitioner` SPI and `PaimonFixedBucketPartitioner` algorithm. Global-commit recovery, checkpoint-state serializers, and the earlier writer/committer rework are left out. Control-row delivery does not imply full online structural DDL support; that limitation is documented. Local clean build/verify passed with 78 tests, including all 10 MiniCluster routing cases. CI specification checks passed with 34 tests, zero failures/errors and two skips; Spotless and E2E test compilation also passed. Docker E2E was not run locally. [Fork CI for this exact commit](https://github.com/201811510411lw/seatunnel/actions/runs/35191929342) is still pending, so I am not claiming full remote CI success. The changes are available in the collaboration PR for the author to incorporate. This upstream PR's head has not changed yet; it will update once those changes are incorporated into its source branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
