201811510411lw commented on PR #12301: URL: https://github.com/apache/seatunnel/pull/12301#issuecomment-5710923863
@DanielLeens @zhangshenghang — correction to my earlier update: the collaboration PR against zhangshenghang's fork, https://github.com/zhangshenghang/seatunnel/pull/19, has been closed without merging. I have opened a standalone PR from my fork to `apache/seatunnel:dev`: https://github.com/apache/seatunnel/pull/12366. The new PR contains one commit, `5de24b8cb`, based on `dev` at `1650a04cd`. It retains the original `SupportSinkDataPartition` / `SinkDataPartitioner` SPI and `PaimonFixedBucketPartitioner` from #12301, with zhangshenghang credited as co-author, and adds the focused fixes from your review: 1. Resolve routing through the actual `MultiTableSink` wrapper, including mixed-routing and duplicate-physical-target rejection. 2. Route schema-control rows by `schema_subtask_id` without invoking data conversion, and preserve broadcast delivery when source/sink parallelism differs. 3. Cover the real factory → wrapped sink → processor path with MiniCluster tests and Paimon readback, including checkpoint-boundary changes; extend the existing Paimon E2E suite. Global-commit recovery, new checkpoint-state serializers, and writer/committer rework remain outside this PR. Safe control-row delivery does not claim full online structural DDL support. Local JDK 8 validation on this branch passed: 83 tests including 10 MiniCluster cases; CI specification checks reported 34 tests with 2 skips and no failures/errors, including all four Markdown checks. Formatting and packaged-class consistency checks passed. The updated E2E test compiled; Docker E2E was not run locally. Full remote CI is still pending. This update does not change #12301's branch. The implementation is now available for review in #12366; your earlier comments on the referenced candidate are not being presented as approval of this new PR. Sorry for the confusion about the contribution target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
