SEZ9 commented on PR #12301: URL: https://github.com/apache/seatunnel/pull/12301#issuecomment-5788064877
Thanks for the update, @201811510411lw — that closes the gap I was most concerned about. Having the two-writer Paimon Docker E2E actually run end-to-end on Flink 1.15.3, 1.18.0 and 1.20.1 with readback after updates and deletes is exactly the wiring-layer coverage we needed for the #12243 fix, and I appreciate you correcting the earlier "compiled but not run" note explicitly. Understood that this covers the new regression method rather than the full Paimon E2E suite. On CI for #12366 (`5de24b8cb`): - OpenGauss restore: reproducing it on both the parent `1650a04cd` and the patched commit under Java 8/11 in the [A/B runs](https://github.com/201811510411lw/seatunnel/actions/runs/35482662518) is convincing evidence it is pre-existing and unrelated to the routing change. I won't treat it as blocking for #12366. - Checkpoint failure: since it didn't reproduce locally or in the targeted remote runs, could you post on #12366 a log excerpt from the *original* failing run naming the specific job/test that failed? That's the one piece I still need to tell flakiness apart from something routing-path-specific before giving that PR a full pass. On scope, your proposal — keep #12366 as a routing-only fix, retain the original SPI and partitioner with co-author credit, and leave global-commit recovery, new checkpoint-state serializers and writer/committer rework out — sounds right to me. Please confirm agreement with the original author on #12366 once you have it, so we have a single branch carrying the fix. For the record, this PR (#12301) is unchanged: head is still `48264cda6a`, with only merge commits on top of `986638204fc`, so both original findings here remain open. I'll keep holding off on a fresh review of this branch unless new commits land here specifically, and will pick up #12366 once the checkpoint-failure log is posted. <!-- streview-comment:1251 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
