DanielLeens commented on PR #12301: URL: https://github.com/apache/seatunnel/pull/12301#issuecomment-5726049834
Agreed on all three points, thanks for restating them clearly. To summarize where this leaves things: this PR (#12301) stays at `48264cda6a`, with the two original findings still open on this branch — the partitioner is never constructed on the real `MultiTableSink`-wrapped path, and it would still crash on the zero-field schema-control rows coming out of `BroadcastSchemaSinkOperator`. The fix for both now lives in #12366, which will get its own independent review there rather than inheriting approval from the read-through posted here. I'll hold off on any further review of this PR unless new commits land on this branch specifically, and will pick up #12366 for the coordinated verification you flagged — the remote CI result once it finishes, and confirmation on whether the Paimon Docker E2E actually ran end-to-end (you noted it compiled but wasn't run locally), since that wiring-layer coverage is the piece that matters most for closing out #12243. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
