SEZ9 commented on issue #11007:
URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5851978677

   @hutiefang76, following up on the Fluss sink OptionRule item you claimed: 
the confirmed scope is that `FlussSinkFactory` registers `bootstrap.servers` as 
required without a `notBlank` condition, while `FlussSourceFactory` already 
applies `notBlank` to its required options, so this remains a sink-only 
validation correction.
   
   Please link the `dev` PR here once it is open. Remaining asks for it:
   
   - Add a nonblank condition only for the existing sink `bootstrap.servers` 
option.
   - Keep `database` and `table` optional so multi-table mode is unaffected.
   - Do not add runtime connectivity checks or change client construction.
   - Include factory tests covering a valid value plus missing, empty, and 
whitespace-only `bootstrap.servers`.
   - Update the EN/ZH option docs only if they do not already state that this 
required endpoint must be nonblank.
   
   If you have already opened the PR, please post the link so it can be 
reviewed against that scope.
   
   <!-- streview-comment:1339 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to