SEZ9 commented on issue #11007:
URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5754638243

   @TianHengZhuang thanks for volunteering for connector-influxdb. That slice 
is fine to take on the same terms as the earlier ones in this tracker: migrate 
only the declarative-eligible checks to `optionRule()` + `Conditions.*`, leave 
external/runtime validation (client, connectivity, credential, format checks) 
untouched, and open one PR against `dev`.
   
   Before you open it, please post here:
   
   1. The exact list of existing imperative checks in the InfluxDB source 
and/or sink factory you intend to move, and which ones you will deliberately 
keep as runtime checks, so the contract is agreed up front.
   2. Confirmation that there is no open PR already covering InfluxDB 
validation (to avoid a repeat of the SensorsData overlap).
   
   For the PR itself, include focused factory tests covering valid configs plus 
each migrated required option when missing, empty, and whitespace-only, keep 
runtime behavior unchanged, update the EN/ZH connector docs, and link the PR 
back to this issue.
   
   <!-- streview-comment:1202 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to