SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5724166601
@Nikk8091 thanks for the connector-sls update on #12352 — the described slice matches the approved scope: declarative nonblank validation limited to the already-required `endpoint`, `project`, `logstore`, `access_key_id`, and `access_key_secret`, applied to both the source and sink factory rules, with focused ConfigValidator coverage (valid, surrounding spaces, and each option individually missing/empty/whitespace-only) and EN/ZH source and sink docs updated. Leaving optional settings, defaults, cursor/start-mode behavior, client construction, credential/network checks, and runtime behavior untouched is exactly what we want here. Two remaining asks before I pick up the review: 1. Please confirm in the PR description that none of the five options changed required/optional status or type — i.e. this only tightens the nonblank constraint on options that were already required strings in both factories, and no new option was introduced. 2. Please confirm the PR is rebased onto the latest `dev` and that the surrounding-spaces test cases assert the existing trim behavior rather than introducing new trimming in the source/sink code. Once those are confirmed on #12352 I'll review it there; let's keep further connector-sls discussion on the PR to keep this tracker readable. <!-- streview-comment:1126 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
