DanielLeens commented on PR #12290: URL: https://github.com/apache/seatunnel/pull/12290#issuecomment-5852851612
Thanks for flagging the javadoc correction on your side. Confirming from my end: head here is still `678c754a7bd6`, unchanged since my 09-14 approval, so there's nothing new on this PR's own diff to re-review. The routing swap is still `(object.hashCode() & Integer.MAX_VALUE) % blockingQueues.size()` becoming `HashUtils.bucketIndex(object.hashCode(), blockingQueues.size())`, and `bucketIndex`'s body is exactly that same expression, so bucket assignment is byte-for-byte identical for every hash and queue count on this diff — no redistribution risk for existing multi-table jobs across the upgrade, and nothing in the `engine-v2-it` failures traces back to `MultiTableSinkWriter`. The "once per second" vs "once per 8 seconds" margin correction is scoped to #12313's javadoc, not to anything in this PR, so it doesn't change my assessment here. My approval stands. Plan unchanged: leave #12290 parked at `678c754a7bd6` until #12311 and #12316 land, then one rebase and a clean `engine-v2-it` run before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
