SEZ9 commented on PR #12290: URL: https://github.com/apache/seatunnel/pull/12290#issuecomment-5944442256
Thanks for the rebase and for the follow-up correction, @SEPURI-SAI-KRISHNA. On the diff side nothing changes for me: the refresh onto `dev` from merge base `ea3df166` left `MultiTableSinkWriter.java` as the single touched file, and your reading of `HashUtils.bucketIndex` is right — `(hash & Integer.MAX_VALUE) % bucketCount` is the same arithmetic as the old inline expression for any positive bucket count, so routing is unchanged and the only new behaviour is the guard on a non-positive count. That is what was approved and it is still what is here. On run `36725638109` for `4d64a4d8`, I agree with the triage as you've laid it out: - `TestFilterRowKindIT.testFilterRowKindMultiTable` — the name is suggestive but, given the arithmetic equivalence above, this change cannot alter which queue a row lands in, and the exit-code signature you quote matches what #12116 already records. Fine to treat as pre-existing. - `iceberg-connector-it (8)` — a `DependencyResolutionException` with no test run is infrastructure, nothing to attribute to this PR. - `MetalakeIT.testMetalake` failing in `startUp` — agreed, one observation is not enough to file on. Two concrete asks before I merge: 1. Please re-trigger the failed legs on `4d64a4d8` (no new commit needed). I'd like to see `iceberg-connector-it (8)` actually resolve its dependencies, and to learn whether `MetalakeIT` recurs or was a one-off. 2. If `MetalakeIT.startUp` fails again on the rerun, drop the trace here so there is a second data point to file against; if it passes, note that too and I'll consider the CI picture settled. Nothing else outstanding from my side. <!-- streview-comment:1455 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
