1328837476-hug commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6145741020
Hi @nzw921rx, following your latest update that HTTP is unclaimed, I'd like to claim the HTTP Sink `url` validation slice under `connector-http`. Please record this scope for @1328837476-hug. I checked current `dev`: `HttpSinkFactory.optionRule()` uses `.required(HttpSinkOptions.URL)` without a nonblank constraint. I found no open PR for this specific change. I'll keep the PR focused on: - Adding `Conditions.notBlank(HttpSinkOptions.URL)` to the existing required rule, preserving the option's name, type and required status. - Extending `HttpFactoryTest` with `ConfigValidator` coverage for valid, missing, empty and whitespace-only values, plus acceptance of padded nonblank values and multi-table URL templates. These tests will not make network requests. - Updating the EN/ZH HTTP Sink option documentation. URL parsing, placeholder substitution, the source factory, client construction, retries and batch-writing behavior will remain unchanged. I'll submit a focused PR against `dev` and link it here. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
