Ashutosh-Panda2004 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6173234679
Hi, I would like to request a focused connector-nats-jetstream slice under this issue. I checked current dev: NatsJetStreamSinkFactory.optionRule() marks url as required without any condition, and the blank check only happens later in NatsJetStreamSinkValidator.requireNonBlank at createSink time, so it is not covered by declarative validation. This connector is not in the tracking table above (it was added in #11460 in August), so I am posting the scope here first. Proposed scope: - Add Conditions.notBlank to the existing required url in NatsJetStreamSinkFactory.optionRule() only. - No new options and no changes to the authentication, format, or native-mapping validation, or to any runtime/connection behaviour, those checks stay in the validator as they are. - Factory tests covering valid, missing, empty, whitespace-only, and padded nonblank url, with the rule-removed regression evidence in the PR description. - EN/ZH docs: the url row states required but not nonblank, so I would add that note there. Once confirmed, I will open one focused PR against dev and link it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
