SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6183433868
Thanks for the update, @1328837476-hug, and for opening the PR for the HTTP Sink `url` nonblank check. A few things to keep the review quick: - Please make sure the PR description links back to this issue so the tracker row for `connector-http` can be updated when it merges. - Confirm the change is limited to adding the nonblank condition on the existing required `url` in `HttpSinkFactory`, with no changes to URL parsing, placeholder handling, HTTP execution, retry behavior, or runtime connectivity checks. - In the PR, call out which factory tests cover each of the agreed cases: valid, missing, empty, whitespace-only, and padded nonblank `url`, so a reviewer can map them without digging. - For the doc updates, note briefly in the PR why the existing option contract needed clarification; if the EN/ZH text already stated "required" correctly, keeping the doc diff minimal is fine. Good to hear the HTTP-base unit tests and scoped build pass locally for you; we'll go by the PR's checks once it is reviewed. I'll pick up the review on the PR itself. <!-- streview-comment:1764 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
