SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6160091588
@ryanmeowy — `connector-cdc-vitess` is yours, continuing on the connector-cdc row. The split you describe is the right one: keep the existing `exclusive(SCHEMA, TABLE_CONFIGS)` and the `startup.mode=specific` conditional as they are, and add only the structural checks at the rule level — an empty `tables_configs`, a `schema` with neither `columns` nor `metadata_table_id`, an entry without its `schema` block, and `table-names` together with `table-pattern`. Agreed that the last pair is at-most-one rather than exactly-one, so a `ConditionExtension` is the correct tool instead of `exclusive`. The checks that need the catalog (table not found in schema metadata, a pattern matching nothing) should stay where they are at runtime; please don't try to pull those into the factory. A few concrete asks for the PR: - Add the rule-level cases to `VitessSourceFactoryTest` as you proposed, with one negative case per new structural check plus a passing baseline config, so each rule is covered independently. - Make sure the new rules don't change behaviour for currently valid configs — in particular, a `schema`-only config and a `tables_configs`-only config must both still pass. - Update the connector docs (EN/ZH) to state the new constraints. - Link the PR back here when it's open so the tracker row for connector-cdc can be updated. <!-- streview-comment:1742 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
