DanielLeens commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6567762703
Thanks, @SEZ9 and @wgzhao. I agree with @SEZ9 that the two extra polling sequences are worth pinning, since they make the F2/F4 behaviour an explicit tested property rather than an implied one. I previously called them optional hardening, and I still do not consider them a defect in the current head, but since the formal recheck is waiting on them, adding them is the quickest way to close this out. @wgzhao, as you offered, please add both cases in the same test function that already covers the polling sequence in `test_diagnose_cli.py`: - A non-dict response ending the poll as `found: false`. - A status-less response, then a valid `jobStatus`, then a status-less response again, to prove `missing_response_seen` is reset only after a valid status. Once pushed, the Python checks should be the only thing to watch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
