SEZ9 commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6620581411
@wgzhao thanks for the detailed walkthrough, and sorry for leaving this hanging. I have not yet re-verified the F1–F8 pointers against the actual diff on `fb542b3e9`, so I would rather not mark anything resolved from the comment alone. I will run the recheck against that head and report back per finding. One item the walkthrough did not cover explicitly is **F2/F4** (post-submit polling aborting on the first status-less / non-dict body and reporting it as "job is not known to the cluster"). Your F5 note mentions a *repeated* status-less branch, which suggests polling may now tolerate a single odd response. Could you confirm on `fb542b3e9`: 1. whether a single status-less or non-dict body still terminates polling, and how many consecutive such responses are needed before the CLI gives up, and 2. whether a non-dict body is still reported as "job is not known to the cluster" or now as a malformed/unexpected response? If `seatunnel-cli/tests/test_diagnose_cli.py` covers those cases, pointing me at the relevant tests would help me locate them quickly when I go through the diff. On the truncated comment: understood, no additional ask there. <!-- streview-comment:2252 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
