sudeephazra commented on PR #12293:
URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6909656054

   @SEZ9  Please review the feedback for the other comments below
   
   PR12293-F1 — Addressed. [ADLSHadoopConf.java (line 
59)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConf.java:59)
 uses the validator’s required() helper to obtain trimmed account, container, 
endpoint, and authentication values. Advanced-property keys and values are also 
trimmed before entering Hadoop configuration. [ADLSHadoopConfTest.java (line 
53)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/seatunnel-connectors-v2/connector-file/connector-file-adls/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConfTest.java:53)
 contains whitespace regression cases for Shared Key and OAuth.
   
   PR12293-F4 — Minimum requirement addressed. [ADLSRuntimeCompatibility.java 
(line 
132)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/seatunnel-connectors-v2/connector-file/connector-file-adls-runtime/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSRuntimeCompatibility.java:132)
 validates the authority and tenant before constructing the token endpoint. 
Authority validation requires HTTPS and a parsed host, and rejects user 
information, non-root paths, queries, and fragments. Tenant validation requires 
a GUID or DNS name. Custom HTTPS authorities remain accepted; there is no 
Microsoft Entra host allowlist. The option and docs explicitly describe this 
trust limitation.
   
   PR12293-F3 — Addressed. Naming rules, authentication mutual exclusion, and 
blocked advanced-property keys are documented in all four references: [English 
source (line 
106)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/en/connectors/source/ADLSFile.md:106),
 [English sink (line 
100)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/en/connectors/sink/ADLSFile.md:100),
 [Chinese source (line 
90)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/zh/connectors/source/ADLSFile.md:90),
 and [Chinese sink (line 
85)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/zh/connectors/sink/ADLSFile.md:85).
 The [shipped template:39 (line 
39)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/config/v2.batch.adls.config.template:39)
 now uses replacewithaccount and replacewithcontainer, which satisfy the nami
 ng rules. Real storage credentials are still required.
   
   PR12293-F5 — Addressed. The [English sink table (line 
52)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/en/connectors/sink/ADLSFile.md:52)
 and [Chinese sink table (line 
37)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/zh/connectors/sink/ADLSFile.md:37)
 agree on option names, types, and defaults. They include header writing, 
encoding, XML options, both Parquet INT96 options, and multi-table replicas 
exposed by [ADLSFileSinkFactory.java (line 
46)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/sink/ADLSFileSinkFactory.java:46).
   
   PR12293-F7 — Addressed. The [English source doc:74 (line 
74)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/en/connectors/source/ADLSFile.md:74)
 now lists discovery_mode = ONCE and start_mode = EARLIEST, matching the code 
and Chinese documentation.
   
   PR12293-F8 — Addressed through both changes. [ADLSConfigValidator.java (line 
118)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSConfigValidator.java:118)
 blocks additional class-loading, token-provider, identity, and 
credential-provider keys. The [option description:87 (line 
87)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSFileBaseOptions.java:87)
 also states that the denylist is incomplete and requires trusted input.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to