SEZ9 commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6889085276
Thanks for the update at `0ade77782ba42efbb36d5dd2783b63702e3becd8`. Checking my previous findings against the current state of the thread: **Likely addressed — please confirm:** - **PR12293-F6 (account_key in the default log-mask list):** the shared masking-list entry is noted as reconciled with the base. Could you also add a one-line mention of this core-starter change to the PR description (and docs if appropriate), since it affects all connectors, not just ADLS? - **PR12293-F2 (HNS requirement for atomic rename):** the latest review refers to "documented HNS and same-container rename conditions". If that wording landed in the sink doc, please point me to it so I can tick this off. **Still open as far as I can tell — please confirm status or push a follow-up:** - **PR12293-F1:** `ADLSHadoopConf.java` should consume the same trimmed values the validator normalizes, so whitespace from env-var substitution doesn't pass validation and then fail with an un-mapped `IllegalArgumentException` or a worker-side 403. - **PR12293-F4:** the OAuth token endpoint in `ADLSRuntimeCompatibility.java` is still built from unvalidated `authority_host`/`tenant_id`. At minimum enforce HTTPS and a sane host/tenant shape before posting `client_secret`. - **PR12293-F3:** document the validation rules (account_name/container naming, auth mutual exclusion, blocked `hadoop_adls_properties` keys) and fix the shipped template placeholders so they pass those rules. - **PR12293-F5:** align the en/zh sink option tables with each other and with what the factories actually expose. - **PR12293-F7:** the English source doc still needs `discovery_mode` default → `ONCE` and `start_mode` default → `EARLIEST`, matching the code and the Chinese doc. - **PR12293-F8 (LOW):** consider tightening the `hadoop_adls_properties` denylist in `ADLSConfigValidator.java` to also block class-loading and token-provider ABFS keys, or soften the "non-routing, non-credential" wording on the option. If any of the "still open" items were already handled in this push, just reply with a pointer and I'll re-check. Once F1 and F4 are resolved and the docs items are in, I'm happy to do a final pass. <!-- streview-comment:2365 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
