the-other-tim-brown commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2649853042
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionTarget.java:
##########
@@ -161,13 +169,47 @@ private void initializeTableIfRequired(InternalTable
internalTable) {
}
}
+ private void setNameMapping(NameMapping mapping) {
Review Comment:
Can you update these method names or add a javadoc explaining that these
should only be used with user provided field IDs?
New name could be something like `setNameMappingForProvidedFieldIds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
