the-other-tim-brown commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2650099490
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionTarget.java:
##########
@@ -161,13 +169,47 @@ private void initializeTableIfRequired(InternalTable
internalTable) {
}
}
+ private void setNameMapping(NameMapping mapping) {
Review Comment:
I called out in the other comment that this cannot be used when the field
IDs are not supplied since your code will not work in that case due to the bug
in setting the IDs for new fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
