xr-chen commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2650113983
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionTarget.java:
##########
@@ -161,13 +169,47 @@ private void initializeTableIfRequired(InternalTable
internalTable) {
}
}
+ private void setNameMapping(NameMapping mapping) {
Review Comment:
Or if this function should only be called when field IDs are provided,
instead of passing a `NameMapping` object to this function, should I just move
the logic of creating the mapping from the schema into this function and let it
take a `schema`object as the parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
