xr-chen commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2650104283
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionTarget.java:
##########
@@ -161,13 +169,47 @@ private void initializeTableIfRequired(InternalTable
internalTable) {
}
}
+ private void setNameMapping(NameMapping mapping) {
Review Comment:
I understand the problem, but this function doesn't create the name mapping
from the schema, it just adds the storage names to the mapping and commits the
mapping to the table. I don't think it should be only called when the field IDs
are provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
