xr-chen commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2649940524
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionTarget.java:
##########
@@ -161,13 +169,47 @@ private void initializeTableIfRequired(InternalTable
internalTable) {
}
}
+ private void setNameMapping(NameMapping mapping) {
Review Comment:
In theory, it could be used when no field IDs are provided, since the
parameter is a `NameMapping`, not a `Schema` object from which we create the
mapping, it won't cause any issues when field IDs are not supplied in the
source schema if it's called with the existing name mapping of the table (of
course it doesn't have any effects in this case)
Adding a javadoc explaining what it does makes sense, will add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
