Danek - See my comments below.
Steve On 11/1/06, Danek Duvall <danek.duvall at sun.com> wrote: > > On Tue, Oct 31, 2006 at 04:08:40AM -0500, Steven M. Christensen wrote: > > > http://companion.sunfreeware.com/downloads/nonrootwebrev/ > > I haven't looked at the install-sfw files in any detail, figuring that > they'll mostly be mechanical changes, but I looked at the others. > > - why the change in berkeley-db/Makefile.sfw? That line might not be > necessary, but it's not related to nonroot builds, is it? Similarly in > imap/Makefile.sfw. The change in the berkeley-db was an editing error and I have added the line back in and check that it works. It does. The imap changes are in fact related to non-root in a way. The permissons of the files in the source that are being patched were such that the patches would not apply except for root. So I had to make the source files writable. - you remove the call to fix_proto_files from libsane/Makefile.sfw, but I > don't see that file being deleted as part of the webrev. Is that simply > a limitation of webrev on an SVN repo? I forgot to do the svn delete on the fix_proto_files. I have done that now. - in both Makefile.master and Targetdirs, you clear out the values of OWNER > and GROUP wherever they're set. Why not just remove them entirely? I can remove then if it is certain that at least and empty value of the various variables are not needed somewhere. I have update my webrev with the above changes. Danek > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/companion-discuss/attachments/20061102/4f581e48/attachment.html>
