Danek -
I have made the changes you suggest. See my comments below.
The http://companion.sunfreeware.com/downloads/nonrootwebrev/ is
updated. The new code builds cleanly in nightly.
Steve C.
> > - in both Makefile.master and Targetdirs, you clear out the values of OWNER
> > and GROUP wherever they're set. Why not just remove them entirely?
>
> I can remove then if it is certain that at least and empty value of the
> various variables are not needed somewhere.
I think you should probably remove them. But even if you don't, I still
see places in Makefile.master where you're setting GROUP. Is that
intentional?
THESE LINES ARE REMOVED.
- in Makefile.master, you're keeping $(CH) in the definitions of CHOWN and
CHGRP. I'd recommend removing that so that any accidental usage will be
noted in the build logs.
REMOVED.
- You're also keeping the $(CH)-commented versions of INS.file and INS.dir,
which should never be used now (in addition to which, the $(RM) is now
pretty critical when installing files).
REMOVED
- You can remove the trailing semicolon from the SYMLINKS-specific
definition of INS.dir in Targetdirs.
DONE
- in amanda/install-sfw, you've changed a handful of permissions from u-w
to u+w -- can you explain why? I'm seeing similar things in other
install-sfw files, but it's decidedly not consistent.
I HAVE CHANGED THE AMANDA AND TETEX LINES TO CORRECT
THE PERMISSIONS. IN SOME CASES IF THE PERMISSIONS ARE 444,
THEN ACTIONS TAKEN ON THE FILES CANNOT BE DONE EXCEPT
AS ROOT, SO I CHANGED PERMISSIONS IN ORDER TO DO
THE ACTIONS NEEDED AND THEN CHANGED THEM BACK TO
444 OR 555 AS NEEDED. THIS ONLY AFFECT THINGS IN PROTO
AND NOT IN THE PACKAGES THEMSELVES. IF YOU HAVE OTHERS
YOU THINK I SHOULD CHANGE, I CAN.
- in enscripts/install-sfw, you're no longer stripping $BINDIR/states. Not
that I'm a big fan of stripping binaries, but removing the stripping can
be done in another putback, and more consistently.
STRIP PUT BACk IN A PLACE THAT WORKS.
- similarly for fetchmail.
ALSO DONE.
- in ruby/install-sfw, I'd merge the last line of the nawk script back up
to the system(chmod) line.
DONE.
- I don't understand the two chmods of ${PREFIX}/teTeX/doc/* in
tetex/install-sfw.
SEE ABOVE.
--
This messages posted from opensolaris.org
