On Tue, Oct 31, 2006 at 04:08:40AM -0500, Steven M. Christensen wrote:

> http://companion.sunfreeware.com/downloads/nonrootwebrev/

I haven't looked at the install-sfw files in any detail, figuring that
they'll mostly be mechanical changes, but I looked at the others.

- why the change in berkeley-db/Makefile.sfw?  That line might not be
  necessary, but it's not related to nonroot builds, is it?  Similarly in
  imap/Makefile.sfw.

- you remove the call to fix_proto_files from libsane/Makefile.sfw, but I
  don't see that file being deleted as part of the webrev.  Is that simply
  a limitation of webrev on an SVN repo?

- in both Makefile.master and Targetdirs, you clear out the values of OWNER
  and GROUP wherever they're set.  Why not just remove them entirely?

Danek

Reply via email to