On Thu, Nov 02, 2006 at 05:30:51AM -0500, Steven Christensen wrote:
> > - in both Makefile.master and Targetdirs, you clear out the values of OWNER
> > and GROUP wherever they're set. Why not just remove them entirely?
>
> I can remove then if it is certain that at least and empty value of the
> various variables are not needed somewhere.
I think you should probably remove them. But even if you don't, I still
see places in Makefile.master where you're setting GROUP. Is that
intentional?
- in Makefile.master, you're keeping $(CH) in the definitions of CHOWN and
CHGRP. I'd recommend removing that so that any accidental usage will be
noted in the build logs.
- You're also keeping the $(CH)-commented versions of INS.file and INS.dir,
which should never be used now (in addition to which, the $(RM) is now
pretty critical when installing files).
- You can remove the trailing semicolone from the SYMLINKS-specific
definition of INS.dir in Targetdirs.
- in amanda/install-sfw, you've changed a handful of permissions from u-w
to u+w -- can you explain why? I'm seeing similar things in other
install-sfw files, but it's decidedly not consistent.
- in enscripts/install-sfw, you're no longer stripping $BINDIR/states. Not
that I'm a big fan of stripping binaries, but removing the stripping can
be done in another putback, and more consistently.
- similarly for fetchmail.
- in ruby/install-sfw, I'd merge the last line of the nawk script back up
to the system(chmod) line.
- I don't understand the two chmods of ${PREFIX}/teTeX/doc/* in
tetex/install-sfw.
Danek
