Danek -
You indicated that you wanted to know what other changes were
made to the nonrootwebrev in my last modification. These were
some chmod changes in the emacspeak install-sfw file only. All
other changes were ones you have seen before.
Steve C.
> On Thu, Nov 16, 2006 at 02:44:55AM -0800, Steve
> Christensen wrote:
>
> > I think you should probably remove them. But even
> if you don't, I still
> > see places in Makefile.master where you're setting
> GROUP. Is that
> > intentional?
> >
> > THESE LINES ARE REMOVED.
>
> Thanks. Though there's no need to shout ...
>
> > - in Makefile.master, you're keeping $(CH) in the
> definitions of CHOWN and
> > CHGRP. I'd recommend removing that so that any
> accidental usage will be
> > noted in the build logs.
> >
> > REMOVED.
>
> It appears now that IFNOTPROTO and all its references
> can now be removed,
> too.
>
> > - in amanda/install-sfw, you've changed a handful
> of permissions from u-w
> > to u+w -- can you explain why? I'm seeing similar
> things in other
> > install-sfw files, but it's decidedly not
> consistent.
> >
> > I HAVE CHANGED THE AMANDA AND TETEX LINES TO
> CORRECT
> > THE PERMISSIONS. IN SOME CASES IF THE PERMISSIONS
> ARE 444,
> > THEN ACTIONS TAKEN ON THE FILES CANNOT BE DONE
> EXCEPT
> > AS ROOT, SO I CHANGED PERMISSIONS IN ORDER TO DO
> > THE ACTIONS NEEDED AND THEN CHANGED THEM BACK TO
> > 444 OR 555 AS NEEDED. THIS ONLY AFFECT THINGS IN
> PROTO
> > AND NOT IN THE PACKAGES THEMSELVES. IF YOU HAVE
> OTHERS
> > YOU THINK I SHOULD CHANGE, I CAN.
> >
> > - I don't understand the two chmods of
> ${PREFIX}/teTeX/doc/* in
> > tetex/install-sfw.
> >
> > SEE ABOVE.
>
> Yeah. I still don't get it. You're making files in
> teTeX/doc writable,
> then doing a bunch of stuff on files in teTeX/info,
> and then making files
> in teTeX/doc unwritable. I don't see the connection
> between the chmods
> and the intervening actions.
>
> As for amanda, you're not doing anything to the files
> that you just
> chmoded; you're just creating another directory in
> that directory and
> populating it. So again, I don't see what the
> "actions" are.
>
> Danek
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-disc
> uss
>
--
This messages posted from opensolaris.org
