On 03/19/2012 07:40 PM, Scott Talbert wrote: > On Sun, 18 Mar 2012, Phil Dibowitz wrote: > >> + printf "$UDEV_USBNET_RULE\n" >>$file >> >> printf is used elsewhere because we're doing variable interpolation... you >> just need echo here. >> >> Everything else looks good. It's probably easier of you roll the new scripts >> and the start_conc.patch into a single patch (diff -N will grab new files). >> That way you don't need to upload 3 files to the dhcp bug for each new rev >> (and I only have one to grab). But definitely keep it separate from the big >> libconcord patch to usbnet support. > > OK, these changes are done in v4. And I was able to trick CVS into > letting me do a -N on the new files, so they are all in the patch now.
+ $(install_sh_DATA) start_concordance_dhcpd.sh \ + $(DESTDIR)$(sysconfdir)/udev/ + $(install_sh_DATA) start_concordance_dhcpd_wrapper.sh \ + $(DESTDIR)$(sysconfdir)/udev/ These shouldn't go in /etc/udev - they're executable scripts. These should go in $sbindir. You'll of course need to update the udev rule itself as well when you move these. I also wonder if these files should be installed by default. Just because I don't use udev to kick them off doesn't mean I don't want this. + # USBNET rule needs to be outside the other rules since it is a net rule. + echo "$UDEV_USBNET_RULE" >>$file Can you make a function for this? I realize it's only one line, but we shoudl have an emit_udev_usbnet_rules() so (1) it's consistent and (2) we can add stuff in the future if necessary. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
