On 03/16/2012 02:08 PM, Scott Talbert wrote:
> Reworked in v2.

I hate that we have tabs in our sourcecode, but we need to be consistent until
I respace it all... but I"ve kept the shellscripts clean, so can you switch to
spaces for your shell scripts?

        $NMCLI dev disconnect iface $INTERFACE \
          >>$LOG 2>&1

This will fit on one line and still be < 80 chars

Other than that, start_usbnet.sh is good to go. Except it should probably be
called start_dnsmasq.sh.

Also, in your wrapper, please use $()

-- 
Phil Dibowitz                             p...@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't matter
 and those who matter don't mind."
 - Dr. Seuss


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to