On Sat, 17 Mar 2012, Phil Dibowitz wrote: > I hate that we have tabs in our sourcecode, but we need to be consistent until > I respace it all... but I"ve kept the shellscripts clean, so can you switch to > spaces for your shell scripts?
OK, s/tabs/spaces done in v3. > $NMCLI dev disconnect iface $INTERFACE \ > >>$LOG 2>&1 > > This will fit on one line and still be < 80 chars It wouldn't at the existing spacing, but I switched to 4-space indents (to match the existing shell scripts) and now it does. > Other than that, start_usbnet.sh is good to go. Except it should probably be > called start_dnsmasq.sh. I changed the name to start_concordance_dhcpd.sh because I wanted to make sure it would be unique. > Also, in your wrapper, please use $() Done. Also in v3, I made changes to the libconcord Makefile (to install these files) and also to gen_udev_support (to add the new udev rule). Scott ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
