On Thu, 4 Mar 2021 15:27:25 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:
>>> A list of the bugs that our internal testing revealed so far: >> >> Are any of these blockers for integration? Some of them are to do with >> things like features that aren't yet supported, and we can't fix what we >> can't see. > >> > A list of the bugs that our internal testing revealed so far: >> >> Are any of these blockers for integration? Some of them are to do with >> things like features that aren't yet supported, and we can't fix what we >> can't see. > > I don't personally think any of these issues are blockers. It's a great > effort as it is and very much appreciated. Anything else can be fixed as a > followup. > > There might be some legal requirements (i.e. JCK) that I'm not in position to > comment on, however, so someone else might need to chime in here. I was building this PR on a new machine, and I now get the following error: > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:258:31: > error: cast to smaller integer type 'MIDIClientRef' (aka 'unsigned int') > from 'void *' [-Werror,-Wvoid-pointer-to-int-cast] > static MIDIClientRef client = (MIDIClientRef) NULL; > ^~~~~~~~~~~~~~~~~~~~ > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:259:29: > error: cast to smaller integer type 'MIDIPortRef' (aka 'unsigned int') from > 'void *' [-Werror,-Wvoid-pointer-to-int-cast] > static MIDIPortRef inPort = (MIDIPortRef) NULL; > ^~~~~~~~~~~~~~~~~~ > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:260:30: > error: cast to smaller integer type 'MIDIPortRef' (aka 'unsigned int') from > 'void *' [-Werror,-Wvoid-pointer-to-int-cast] > static MIDIPortRef outPort = (MIDIPortRef) NULL; > ^~~~~~~~~~~~~~~~~~ > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:466:32: > error: cast to smaller integer type 'MIDIEndpointRef' (aka 'unsigned int') > from 'void *' [-Werror,-Wvoid-pointer-to-int-cast] > MIDIEndpointRef endpoint = (MIDIEndpointRef) NULL; > ^~~~~~~~~~~~~~~~~~~~~~ > 4 errors generated. As far as I can tell the only difference between the two systems is the xcode version: New system (failing) % xcodebuild -version Xcode 12.5 Build version 12E5244e Old system (working) % xcodebuild -version Xcode 12.4 Build version 12D4e Looks like the newer version of Xcode is being a little stricter with casting? Replacing the NULL with 0 seems to fix the issue. ------------- PR: https://git.openjdk.java.net/jdk/pull/2200