On Fri, 3 Sep 2021 09:10:20 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, 
> @iignatev suggested to create tier4 groups that capture all tests not in 
> tiers{1,2,3}. I have excluded `vmTestbase` and `hotspot:tier4,` because they 
> take 10+ hours on my highly parallel machine. I have also excluded 
> `applications` from `hotspot:tier4`, because they require test dependencies 
> (e.g. jcstress).
> 
> Sample run:
> 
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR  
>  
>>> jtreg:test/hotspot/jtreg:tier4                      426   425     1     0 <<
>>> jtreg:test/jdk:tier4                               2891  2885     4     2 <<
>    jtreg:test/langtools:tier4                            0     0     0     0  
>  
>    jtreg:test/jaxp:tier4                                 0     0     0     0  
>  
> ==============================
> 
> real  64m13.994s
> user  1462m1.213s
> sys   39m38.032s
> 
> 
> There are interesting test failures on my machine, which I would address 
> separately.

Hi Aleksey,

This seems rather arbitrary and subjective to me. The tier 1-3 groupings were 
driven by existing tier 1-3 notions. But here the definition of tier 4 as "all 
the rest except ..." is not really a well-defined meaning for tier 4. I don't 
see that it adds any value. Perhaps there is a need for a group that is 
"everything except tier 1, tier 2, tier 3, applications, ..." but I wouldn't 
call that tier 4.

Cheers,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/5357

Reply via email to