On Tue, 28 Mar 2023 06:28:17 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated image. Before this change, when such a image was being >> launched, the code would assume the byte order in the image to be the native >> order of the host where the image is being launched. That would result in >> failure to launch java, as noted in the linked issue. >> >> The commit in this PR, changes relevant places to not assume native order >> and instead determine the byte order by reading the magic bytes in the image >> file's header content. >> >> A new jtreg test has been added which reproduces the issue and verifies the >> fix. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > use test.jdk system property in test src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 39: > 37: */ > 38: public record Platform(OperatingSystem os, Architecture arch, ByteOrder > endianness) { > 39: private static final Properties KNOWN_ENDIANNESS; I assume this should be renamed to something like PLATFORM_PROPERTIES as the properties are not specific to endianness now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1150405901
