On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey <coff...@openjdk.org> wrote:

>> New functionality in the -XshowSettings menu to display relevant information 
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 15 additional 
> commits since the last revision:
> 
>  - Avoid sharing INDENT variables
>  - Merge branch 'master' into 8281658-showsettings-security
>  - Don't allow bad subcommand values for security component
>  - restore more informative help message
>  - Split long properties for ; also
>  - Pass PrintStream to security helper
>  - Refactor out security code to helper class
>  - Print aliases. Order Provider type/service output.
>  - Incorporate review comments from Roger and tweak some code
>  - Merge branch 'master' into 8281658-showsettings-security
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/da750e20...7e6f5090

Marked as reviewed by rriggs (Reviewer).

src/java.base/share/classes/sun/launcher/LauncherHelper.java line 115:

> 113:     private static StringBuilder outBuf = new StringBuilder();
> 114: 
> 115:     private static final String INDENT = " ".repeat(4);

Revert this, its just making a simple constant into a runtime expression.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14394#pullrequestreview-1517119059
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1254799500

Reply via email to