On Tue, 15 Aug 2023 18:22:00 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revise retrieval of jdk.util.zip.disableZip64ExtraFieldValidation and >> tweak a comment > > src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 3100: > >> 3098: if (sz == 0) { >> 3099: if ( csize == ZIP64_MINVAL || size == >> ZIP64_MINVAL || >> 3100: locoff == ZIP64_MINVAL) { > > Minor nit but you can drop the space in "( csize)" and put the third > condition on L3099 to make it easier to read. > > For the comment, it looks like it is missing a comma after "== 0". Either > that or change it to start with "Some older version of Apache Ant and Apache > Commons ...". Addressed in the latest update. Thank you! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15273#discussion_r1294975044