On Tue, 15 Aug 2023 10:21:42 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add additional zip to the DataProvider so it is exercised
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 132:
>
>> 130: GetPropertyAction.privilegedGetProperty(
>> 131: "jdk.util.zip.disableZip64ExtraFieldValidation",
>> "false")
>> 132: .equalsIgnoreCase("true");
>
> This doesn't quite work for -Djdk.util.zip.disableZip64ExtraFieldValidation,
> this is closer to what you want here:
>
> private static final boolean DISABLE_ZIP64_EXTRA_VALIDATION;
> static {
> String value = GetPropertyAction.privilegedGetProperty(
> "jdk.util.zip.disableZip64ExtraFieldValidation");
> if (value == null) {
> DISABLE_ZIP64_EXTRA_VALIDATION = false;
> } else {
> DISABLE_ZIP64_EXTRA_VALIDATION = value.isEmpty() ||
> value.equalsIgnoreCase("true");
> }
> }
Reworked similar to above.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15273#discussion_r1294857154
