On Fri, 20 Mar 2026 21:37:12 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Please review this PR which updates the specification of
>> `ZipOutputStream.setComment(String)` to match the long-standing behavior of
>> throwing `IllegalArgumentException` when a comment contains characters which
>> are unmappable using the `Charset` passed in the constructor.
>>
>> A new tests is added to reproduce calling setComment with unmappable
>> characters and verify that it throws IAE.
>>
>> A CSR has been drafted. Its specification section will be updated after an
>> initial round of review of the specification text in this PR.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove unused import
src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 145:
> 143: * Sets the ZIP file comment.
> 144: *
> 145: * @param comment the comment string. Passing {@code null} or
> the empty string
"the empty string" seems not quite right. Perhaps "the" -> "an"?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r2977158597
