On Mon, 23 Mar 2026 19:35:22 GMT, Lance Andersen <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused import
>
> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 145:
>
>> 143: * Sets the ZIP file comment.
>> 144: *
>> 145: * @param comment the comment string. Passing {@code null} or
>> the empty string
>
> "the empty string" seems not quite right. Perhaps "the" -> "an"?
I see "an empty string" and "the empty string" both being used throughout the
JDK. But in this case, yes, maybe "an" flows better since we're talking about
the concrete and actual string passed and not string theory (pun intended:).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r2977218464
